img_mgmt: Verify memory controller node while determining a running application partition. #25704

tomchy · 2025-11-20T14:23:41Z

Verify memory controller node while determining a running application partition.

Ref: NCSIDB-1773

Copilot

Pull Request Overview

This PR updates the img_mgmt subsystem to use absolute addresses when determining the running application partition, instead of relative offsets. The change adds support for CONFIG_USE_DT_CODE_PARTITION by computing absolute flash addresses from device tree properties.

Adds new macro definitions for absolute address calculation using device tree
Updates the running partition check to use address range comparison instead of exact offset matching
Updates Zephyr SDK revision to pull/3520/head

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
west.yml	Updates Zephyr revision to pull/3520/head to incorporate required changes
subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt.c	Adds CONFIG_USE_DT_CODE_PARTITION support with absolute address calculation macros

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt.c

NordicBuilder · 2025-11-20T14:24:23Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`dc05376` (`main`)	nrfconnect/sdk-zephyr#3520	nrfconnect/sdk-zephyr#3520/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-11-20T14:28:11Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 13

Inputs:

Sources:

sdk-nrf: PR head: 2666d2caada676b81e08cc079f1d6c99b27179c8
zephyr: PR head: 78626a68d4f57b357244ab82e61e3077675bda6b

more details

sdk-nrf:

PR head: 2666d2caada676b81e08cc079f1d6c99b27179c8
merge base: f3179a39b3b87da07bebdc2fe9712a6b26fc3b68
target head (main): f3179a39b3b87da07bebdc2fe9712a6b26fc3b68
Diff

zephyr:

PR head: 78626a68d4f57b357244ab82e61e3077675bda6b
merge base: dc05376c170fc2739a4881629caf49c40d485a9e
target head (main): dc05376c170fc2739a4881629caf49c40d485a9e
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (8)

include
│  │ flash_map_pm.h
subsys
│  ├── mgmt
│  │  ├── mcumgr
│  │  │  ├── grp
│  │  │  │  ├── img_mgmt
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ img_mgmt.c
west.yml
zephyr
│  ├── include
│  │  ├── zephyr
│  │  │  ├── storage
│  │  │  │  │ flash_map.h
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54h
│  │  │  │  │ soc.c
│  ├── subsys
│  │  ├── dfu
│  │  │  ├── img_util
│  │  │  │  │ flash_img.c
│  │  ├── mgmt
│  │  │  ├── mcumgr
│  │  │  │  ├── grp
│  │  │  │  │  ├── img_mgmt
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ img_mgmt.c
│  ├── tests
│  │  ├── subsys
│  │  │  ├── dfu
│  │  │  │  ├── img_util
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c

Outputs:

Toolchain

Version: 4e36fbc961
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4e36fbc961_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 2085
- sdk-zephyr test count: 555
✅ Integration tests
- ✅ test-sdk-audio
- ✅ test_ble_nrf_config
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-thread-main
- ✅ test-sdk-find-my
- ✅ test-low-level
- ✅ test-sdk-mcuboot
- ✅ test-sdk-dfu
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-11-21T11:24:10Z

You can find the documentation preview for this PR here.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

include/flash_map_pm.h:1

Inconsistent indentation: line 77 uses a tab followed by the condition, while line 78 uses two tabs. The macro arguments should have consistent indentation aligned with the opening parenthesis or follow a uniform pattern.

/*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

west.yml

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

include/flash_map_pm.h:1

The indentation is inconsistent - line 77 uses a tab, while line 78 uses two tabs. The opening parenthesis on line 78 should align with line 77 for consistency, using a single tab followed by spaces if needed.

/*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Use absolute addresses while determining a running application partition. Ref: NCSIDB-1773 Signed-off-by: Tomasz Chyrowicz <[email protected]>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

include/flash_map_pm.h

Copilot AI review requested due to automatic review settings November 20, 2025 14:23

NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 20, 2025

Copilot AI reviewed Nov 20, 2025

View reviewed changes

subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt.c Outdated Show resolved Hide resolved

subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt.c Outdated Show resolved Hide resolved

NordicBuilder added manifest-zephyr DNM labels Nov 20, 2025

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch 2 times, most recently from b8653b8 to a76b1ee Compare November 21, 2025 11:23

Copilot AI review requested due to automatic review settings November 21, 2025 11:23

Copilot AI reviewed Nov 21, 2025

View reviewed changes

tomchy changed the title ~~img_mgmt: Use absolute address while checking app~~ img_mgmt: Verify memory controller node while determining a running application partition. Nov 21, 2025

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch from a76b1ee to a51e832 Compare November 24, 2025 11:33

Copilot AI review requested due to automatic review settings November 24, 2025 13:11

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch from a51e832 to 0ef2334 Compare November 24, 2025 13:11

Copilot AI reviewed Nov 24, 2025

View reviewed changes

west.yml Show resolved Hide resolved

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch from 0ef2334 to 3b2c30e Compare November 25, 2025 08:37

tomchy marked this pull request as ready for review November 25, 2025 16:23

tomchy requested review from a team as code owners November 25, 2025 16:23

Copilot AI review requested due to automatic review settings November 25, 2025 16:23

Copilot AI reviewed Nov 25, 2025

View reviewed changes

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch from 3b2c30e to c52a4eb Compare November 25, 2025 16:24

img_mgmt: Use absolute address while checking app

2666d2c

Use absolute addresses while determining a running application partition. Ref: NCSIDB-1773 Signed-off-by: Tomasz Chyrowicz <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 10:36

tomchy force-pushed the bugfix/soc/NCSIDB-1773_Handle_extmem branch from c52a4eb to 2666d2c Compare November 27, 2025 10:36

Copilot AI reviewed Nov 27, 2025

View reviewed changes

include/flash_map_pm.h Show resolved Hide resolved

tomchy added this to the 3.2.0 milestone Nov 27, 2025

tomchy added the bugfix Fixes a known bug label Nov 27, 2025

tejlmand approved these changes Nov 27, 2025

View reviewed changes

nvlsianpu approved these changes Nov 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

img_mgmt: Verify memory controller node while determining a running application partition. #25704

img_mgmt: Verify memory controller node while determining a running application partition. #25704

tomchy commented Nov 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

NordicBuilder commented Nov 20, 2025 •

edited

Loading

Uh oh!

NordicBuilder commented Nov 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

img_mgmt: Verify memory controller node while determining a running application partition. #25704

Are you sure you want to change the base?

img_mgmt: Verify memory controller node while determining a running application partition. #25704

Conversation

tomchy commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

NordicBuilder commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tomchy commented Nov 20, 2025 •

edited

Loading

NordicBuilder commented Nov 20, 2025 •

edited

Loading

NordicBuilder commented Nov 20, 2025 •

edited

Loading